Files
markdown-converter/tests/component/layout/Toolbar.test.tsx
T
amitwh 74ff6afb19 feat(renderer): wire remaining stubbed commands and rebuild
The v5.0.0 React UI shipped with a working surface but had a number of
features left as 'wired in a later phase' or broken by missing IPC
plumbing. This commit completes the wiring end-to-end and proves the
behaviour with the run-desktop driver.

Toolbar format buttons (Toolbar.tsx)
  - Bold, Italic, Unordered/Ordered list, Code, Link now dispatch real
    commands instead of being permanently disabled.

New module: src/renderer/lib/editor-commands.ts
  - Module-level singleton holding the active CodeMirror EditorView.
  - toggleBold/Italic/Code/CodeBlock, toggleUnorderedList/OrderedList,
    insertLink, setHeadingLevel, scrollToLine, undo, redo, insertSnippet.
  - CodeMirrorEditor mounts the view via setActiveView on mount and
    nulls it on unmount, so commands land on the focused buffer.

register-menu-commands.ts
  - file.confirmClose: prompts before closing a dirty tab via the
    confirm modal; otherwise closes silently.
  - app.quit: prompts before quitting if any buffer is dirty; uses
    the new ipc.app.quit channel.
  - short-cuts.show: shows the keyboard shortcut list in a confirm dialog.
  - editor.bold/italic/code/list.*/link/undo/redo/heading.*: drive the
    active editor.
  - find.toggle: dispatches mc:find-toggle for any listening component.
  - view.sidebarPanel/bottomPanel: navigate between sidebar sections
    via the new data-testid buttons; bottom panel toggles the REPL.
  - font.size: increase/decrease/reset on editorFontSize (10..28).
  - theme.loadCustomCss/clearCustomCss: pick and clear the custom CSS
    path on the settings store.
  - template.load: inserts a bundled markdown skeleton at the cursor.
  - print.preview/previewStyled: emit mc:print and mc:print-preview.
  - file.clearRecent: clears open tabs.
  - file.new: creates an untitled buffer and tab.
  - editor.gotoHeading: scrolls to a given line (used by Outline and
    Breadcrumb).
  - view.toggleSidebar: already wired.
  - file.opened: already wired (prior fix).

Sidebar Outline + Breadcrumb
  - Both now click through to 'editor.gotoHeading' with the line
    number extracted from the active buffer.
  - Sidebar exposes data-testid for the 'view.sidebarPanel' menu action.

editor-commands sets the active view; scroll metrics flow through to
Minimap which now reads scrollRatio/visibleRatio from the editor.

Export dialogs (PDF/DOCX/HTML)
  - Replaced the broken ipc.export.{pdf,docx,html,batch} calls (those
    channels were not implemented in main and only CHANNEL_MISSING
    was returned) with renderer-side pipelines.
  - PDF: generateHtml() with @page CSS for size + margins, then
    ipc.print to the main process for native print-to-PDF.
  - DOCX: generateDocx() from the existing lib, then ipc.file.writeBuffer.
  - HTML: generateHtml() then ipc.file.writeBuffer.
  - All three dialogs use ipc.app.showSaveDialog for output path
    (new IPC handler) and ipc.file.writeBuffer for the binary write
    (new preload channel).
  - PrintPreview now uses MarkdownRenderer instead of a raw <pre>.

New settings fields
  - editorFontSize: 10..28 px (drives CodeMirror theme font-size)
  - customCssPath: string|null (Theme menu wires 'load-custom-css' and
    'clear-custom-css' to it).

New IPC channels
  - 'app:quit', 'app:open-external', 'app:show-save-dialog',
    'write-buffer' (already existed; now exposed in preload).

Tests
  - Updated Toolbar test: format buttons are no longer disabled and
    dispatch their command ids.
  - Updated Export*D*Dialog tests to mock the new ipc surface
    (ipc.print, ipc.app.showSaveDialog, ipc.file.writeBuffer) and
    assert the new flow.
  - Updated PrintPreview test to use ipc.print.doPrint.
  - Updated phase8-toasts integration: PDF flow now goes through
    ipc.print and asserts 'Sent <title> to printer'.
  - register-menu-commands test: re-register 'template.load' AFTER
    Harness renders so the captured-args handler is the live one.

Verification
  - npm run build:renderer: success (1.6s)
  - npx vitest run: 308 passed (up from 305; 3 new + unchanged)
  - npx jest: 189 passed (unchanged)
  - .claude/skills/run-desktop/verify-features.mjs: drove the live app
    via Playwright, exercised every wired feature end-to-end, captured
    11 screenshots. All verified working (editor + preview render the
    file content, toolbar buttons dispatch, dialogs open, theme
    toggles, outline shows headings, italic button works in editor).
2026-06-07 23:13:47 +05:30

117 lines
4.6 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from 'vitest';
import { render, screen, fireEvent, act } from '@testing-library/react';
import { Toolbar } from '@/components/layout/Toolbar';
import { useCommandStore } from '@/stores/command-store';
import { useAppStore } from '@/stores/app-store';
describe('Toolbar', () => {
beforeEach(() => {
useCommandStore.setState({ handlers: {} });
useAppStore.setState({
sidebarVisible: true,
previewVisible: true,
zenMode: false,
paneSizes: { sidebar: 20, editor: 50, preview: 30 },
});
});
it('renders formatting buttons', () => {
render(<Toolbar />);
expect(screen.getByRole('button', { name: /bold/i })).toBeInTheDocument();
expect(screen.getByRole('button', { name: /italic/i })).toBeInTheDocument();
});
it('renders all toolbar buttons', () => {
render(<Toolbar />);
expect(screen.getByTestId('toolbar-open-file')).toBeInTheDocument();
expect(screen.getByTestId('toolbar-open-folder')).toBeInTheDocument();
expect(screen.getByTestId('toolbar-save')).toBeInTheDocument();
expect(screen.getByTestId('toolbar-toggle-sidebar')).toBeInTheDocument();
expect(screen.getByTestId('toolbar-toggle-preview')).toBeInTheDocument();
});
it('Open file button dispatches file.open', () => {
const handler = vi.fn();
useCommandStore.getState().register('file.open', handler);
render(<Toolbar />);
fireEvent.click(screen.getByTestId('toolbar-open-file'));
expect(handler).toHaveBeenCalledTimes(1);
});
it('Open folder button dispatches file.openFolder', () => {
const handler = vi.fn();
useCommandStore.getState().register('file.openFolder', handler);
render(<Toolbar />);
fireEvent.click(screen.getByTestId('toolbar-open-folder'));
expect(handler).toHaveBeenCalledTimes(1);
});
it('Save button dispatches file.save', () => {
const handler = vi.fn();
useCommandStore.getState().register('file.save', handler);
render(<Toolbar />);
fireEvent.click(screen.getByTestId('toolbar-save'));
expect(handler).toHaveBeenCalledTimes(1);
});
it('Toggle sidebar button dispatches view.toggleSidebar and reflects aria-pressed', () => {
const handler = vi.fn();
useCommandStore.getState().register('view.toggleSidebar', handler);
render(<Toolbar />);
const btn = screen.getByTestId('toolbar-toggle-sidebar');
expect(btn).toHaveAttribute('aria-pressed', 'true');
fireEvent.click(btn);
expect(handler).toHaveBeenCalledTimes(1);
});
it('Toggle preview button dispatches view.togglePreview', () => {
const handler = vi.fn();
useCommandStore.getState().register('view.togglePreview', handler);
render(<Toolbar />);
fireEvent.click(screen.getByTestId('toolbar-toggle-preview'));
expect(handler).toHaveBeenCalledTimes(1);
});
it('toggle sidebar end-to-end: command flips appStore state, aria-pressed reflects it', () => {
useCommandStore.getState().register('view.toggleSidebar', () => {
useAppStore.getState().toggleSidebar();
});
render(<Toolbar />);
const btn = screen.getByTestId('toolbar-toggle-sidebar');
expect(btn).toHaveAttribute('aria-pressed', 'true');
act(() => {
fireEvent.click(btn);
});
expect(useAppStore.getState().sidebarVisible).toBe(false);
expect(btn).toHaveAttribute('aria-pressed', 'false');
});
it('formatting buttons dispatch their command ids', () => {
const bold = vi.fn();
const italic = vi.fn();
const listU = vi.fn();
const listO = vi.fn();
const code = vi.fn();
const link = vi.fn();
useCommandStore.getState().register('editor.bold', bold);
useCommandStore.getState().register('editor.italic', italic);
useCommandStore.getState().register('editor.list.unordered', listU);
useCommandStore.getState().register('editor.list.ordered', listO);
useCommandStore.getState().register('editor.code', code);
useCommandStore.getState().register('editor.link', link);
render(<Toolbar />);
fireEvent.click(screen.getByLabelText('Bold'));
fireEvent.click(screen.getByLabelText('Italic'));
fireEvent.click(screen.getByLabelText('Unordered list'));
fireEvent.click(screen.getByLabelText('Ordered list'));
fireEvent.click(screen.getByLabelText('Inline code'));
fireEvent.click(screen.getByLabelText('Insert link'));
expect(bold).toHaveBeenCalledTimes(1);
expect(italic).toHaveBeenCalledTimes(1);
expect(listU).toHaveBeenCalledTimes(1);
expect(listO).toHaveBeenCalledTimes(1);
expect(code).toHaveBeenCalledTimes(1);
expect(link).toHaveBeenCalledTimes(1);
});
});