16 Commits
Author SHA1 Message Date
amitwh 58ca3014d8 fix(modals): drop shadcn-style aria-describedby to silence Radix warning
Every DialogContent had aria-describedby="X-desc" and every
DialogDescription had a matching id="X-desc". That pattern is the
default shadcn/ui recipe, but it breaks Radix 1.1.x.

Root cause: Radix auto-generates a descriptionId via useId() (e.g. :r0:)
and stores it in the Dialog context. The DescriptionWarning effect does
`document.getElementById(descriptionId)` and warns if the element is
missing. When the description element's id is overridden to
"welcome-desc", the DOM has id="welcome-desc" but the context still has
:r0:, so the lookup misses and the warning fires on every dialog open.

Fix: drop both overrides. Let Radix manage the id and aria-describedby
itself. Screen-reader semantics are unchanged (Radix still wires
Content -> Description via the auto-generated id).

Touched: 12 modal files (11 DialogContent/DialogDescription pairs +
SettingsSheet which uses Sheet). +1 regression test in
WelcomeDialog.test.tsx that spies on console.warn and asserts the
"Missing Description" message is never emitted.

Tests: 306/306 pass (was 305).

Long-term memory: radix-aria-describedby-anti-pattern.md captures the
do-not-reintroduce rule for future agents.
2026-06-06 20:45:13 +05:30
amitwh a62511e7ed feat(renderer): FindInFilesDialog (cross-file search with regex) 2026-06-06 08:04:49 +05:30
amitwh a6c6e3696e feat(renderer): WordExportDialog (docx export with template picker) 2026-06-06 08:02:19 +05:30
amitwh 1b2ab437d1 feat(renderer): TableGeneratorDialog (markdown table generator) 2026-06-06 07:45:18 +05:30
amitwh efc7709f66 feat(renderer): AsciiGeneratorDialog (figlet text-to-ASCII-art) 2026-06-06 07:40:20 +05:30
amitwh 24c6675c82 fix(test): use mockRejectedValue for IPC error in ExportPdfDialog test 2026-06-05 23:17:57 +05:30
amitwh 9306a9c23b feat(renderer): SettingsSheet (5 tabs: editor, theme, export, plugins, about) 2026-06-05 19:41:18 +05:30
amitwh f25d856a2a feat(renderer): ExportBatchDialog (format, concurrency, file list) 2026-06-05 19:30:15 +05:30
amitwh 76fed872ce test(renderer): assert toggled standalone value in ExportHtmlDialog test 2026-06-05 19:28:44 +05:30
amitwh 9de14df016 feat(renderer): ExportHtmlDialog (standalone, highlight style, ascii tables) 2026-06-05 19:27:16 +05:30
amitwh 5f0b4c9c4e feat(renderer): ExportDocxDialog (template picker + ascii tables) 2026-06-05 19:23:40 +05:30
amitwh 7d083a024d feat(renderer): ExportPdfDialog (format, margins, ascii tables) 2026-06-05 19:19:18 +05:30
amitwh 026a4d9fac feat(renderer): WelcomeDialog (first-launch quick-start) 2026-06-05 19:07:14 +05:30
amitwh a461b62dd3 feat(renderer): ConfirmDialog (generic title/body/onConfirm) 2026-06-05 19:01:06 +05:30
amitwh 1cd316caf1 feat(renderer): AboutDialog (version + GitHub link) 2026-06-05 18:47:14 +05:30
amitwh 2bdb380130 feat(renderer): ModalLayer shell (dispatches to 7 modal types) 2026-06-05 18:36:28 +05:30