feat(renderer): FindInFilesDialog (cross-file search with regex)

This commit is contained in:
2026-06-06 08:04:49 +05:30
parent a6c6e3696e
commit a62511e7ed
2 changed files with 184 additions and 0 deletions
@@ -0,0 +1,111 @@
import { useState } from 'react';
import { Dialog, DialogContent, DialogDescription, DialogFooter, DialogHeader, DialogTitle } from '@/components/ui/dialog';
import { Button } from '@/components/ui/button';
import { Checkbox } from '@/components/ui/checkbox';
import { Input } from '@/components/ui/input';
import { Label } from '@/components/ui/label';
import { useAppStore } from '@/stores/app-store';
import { useFileStore } from '@/stores/file-store';
import { ipc } from '@/lib/ipc';
interface SearchResult {
filePath: string;
line: number;
content: string;
}
export function FindInFilesDialog() {
const closeModal = useAppStore((s) => s.closeModal);
const rootPath = useFileStore((s) => s.rootPath);
const openFile = useFileStore((s) => s.openFile);
const [query, setQuery] = useState('');
const [isRegex, setIsRegex] = useState(false);
const [caseSensitive, setCaseSensitive] = useState(false);
const [results, setResults] = useState<SearchResult[]>([]);
const [submitting, setSubmitting] = useState(false);
const [error, setError] = useState<string | null>(null);
const handleSearch = async () => {
if (!query || !rootPath) return;
setSubmitting(true);
setError(null);
const result = await ipc.file.search({ rootPath, query, isRegex, caseSensitive });
if (!result.ok) {
setError(result.error.message);
setSubmitting(false);
return;
}
setResults(result.data ?? []);
setSubmitting(false);
};
const handleResultClick = (filePath: string) => {
openFile(filePath);
closeModal();
};
return (
<Dialog open onOpenChange={(o) => !o && closeModal()}>
<DialogContent aria-describedby="find-desc" className="max-w-2xl">
<DialogHeader>
<DialogTitle>Find in files</DialogTitle>
<DialogDescription id="find-desc">
{rootPath ? `Search in ${rootPath}` : 'No folder open'}
</DialogDescription>
</DialogHeader>
<div className="space-y-3">
<div>
<Label htmlFor="find-query">Query</Label>
<Input
id="find-query"
aria-label="Query"
value={query}
onChange={(e) => setQuery(e.target.value)}
onKeyDown={(e) => e.key === 'Enter' && handleSearch()}
/>
</div>
<div className="flex gap-4">
<label className="flex items-center gap-2">
<Checkbox checked={isRegex} onCheckedChange={(c) => setIsRegex(!!c)} aria-label="Regex" />
Regex
</label>
<label className="flex items-center gap-2">
<Checkbox checked={caseSensitive} onCheckedChange={(c) => setCaseSensitive(!!c)} aria-label="Case sensitive" />
Case sensitive
</label>
</div>
{error && (
<div role="alert" className="rounded border border-destructive/40 bg-destructive/5 p-2 text-xs text-destructive">
{error}
</div>
)}
{results.length > 0 && (
<div>
<Label>{results.length} result{results.length === 1 ? '' : 's'}</Label>
<div className="max-h-64 overflow-auto rounded border border-border bg-card/20 text-xs">
{results.map((r, i) => (
<button
key={`${r.filePath}:${r.line}:${i}`}
onClick={() => handleResultClick(r.filePath)}
className="block w-full truncate border-b border-border/30 px-2 py-1 text-left hover:bg-card/50"
data-testid="find-result"
>
<span className="font-mono text-muted-foreground">{r.filePath}:{r.line}</span>
<span className="ml-2">{r.content}</span>
</button>
))}
</div>
</div>
)}
</div>
<DialogFooter>
<Button variant="ghost" onClick={closeModal} disabled={submitting}>Close</Button>
<Button onClick={handleSearch} disabled={submitting || !query}>
{submitting ? 'Searching…' : 'Search'}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
);
}
@@ -0,0 +1,73 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { FindInFilesDialog } from '@/components/modals/FindInFilesDialog';
import { useFileStore } from '@/stores/file-store';
vi.mock('@/lib/ipc', () => ({
ipc: {
file: {
search: vi.fn(),
},
},
}));
import { ipc } from '@/lib/ipc';
import { useAppStore } from '@/stores/app-store';
describe('FindInFilesDialog', () => {
beforeEach(() => {
localStorage.clear();
vi.clearAllMocks();
useFileStore.setState({ rootPath: '/project' } as any);
useAppStore.setState({ modal: { kind: null } } as any);
});
it('renders with a query input and toggles', () => {
render(<FindInFilesDialog />);
expect(screen.getByText(/find in files/i)).toBeInTheDocument();
expect(screen.getByRole('textbox', { name: /query/i })).toBeInTheDocument();
expect(screen.getByRole('checkbox', { name: /regex/i })).toBeInTheDocument();
expect(screen.getByRole('checkbox', { name: /case/i })).toBeInTheDocument();
expect(screen.getByRole('button', { name: /search/i })).toBeInTheDocument();
});
it('submits a search and shows results', async () => {
(ipc.file.search as any).mockResolvedValueOnce({
ok: true,
data: [
{ filePath: '/project/a.md', line: 5, content: 'matching line' },
{ filePath: '/project/b.md', line: 12, content: 'another match' },
],
});
render(<FindInFilesDialog />);
await userEvent.type(screen.getByRole('textbox', { name: /query/i }), 'match');
await userEvent.click(screen.getByRole('button', { name: /search/i }));
expect(await screen.findByText('/project/a.md:5')).toBeInTheDocument();
expect(await screen.findByText(/another match/)).toBeInTheDocument();
});
it('clicking a result calls useFileStore.openFile', async () => {
(ipc.file.search as any).mockResolvedValueOnce({
ok: true,
data: [{ filePath: '/project/a.md', line: 5, content: 'matching line' }],
});
const openFileSpy = vi.fn();
useFileStore.setState({ openFile: openFileSpy, rootPath: '/project' } as any);
render(<FindInFilesDialog />);
await userEvent.type(screen.getByRole('textbox', { name: /query/i }), 'match');
await userEvent.click(screen.getByRole('button', { name: /search/i }));
const result = await screen.findByText('/project/a.md:5');
await userEvent.click(result);
// openFile is called with the filePath; the test verifies it was called
expect(openFileSpy).toHaveBeenCalled();
});
it('shows an error banner when search fails', async () => {
(ipc.file.search as any).mockResolvedValueOnce({ ok: false, error: { code: 'E', message: 'regex invalid' } });
render(<FindInFilesDialog />);
await userEvent.paste('[invalid', { initialSelectionStart: 0, initialSelectionEnd: 0 });
await userEvent.click(screen.getByRole('button', { name: /search/i }));
expect(await screen.findByText(/regex invalid/i)).toBeInTheDocument();
});
});