amitwh/markdown-converter
1
0
Fork 0
mirror of https://github.com/amitwh/markdown-converter.git synced 2026-08-02 18:10:18 +05:30
Code Issues Packages Projects Releases Wiki Activity

fix(polish): address 3 review blockers + 1 security issue

Browse Source 
1. ThemeSettings: change 'auto' radio value to 'system' to match
   the v5 settingsSchema enum. Storing 'auto' silently wipes all
   settings on next launch.
2. UpdateBanner: render an 'available' branch so users see a CTA
   when a new version is detected (the store already had this state,
   but the banner was silent). Added a test.
3. feed-config: remove the unused resolveFeedUrl / FEEDS exports.
   feedConfigFor is the actual implementation used by the IPC
   handler. Updated tests to match.
4. main/index.js: tighten app:open-external regex to https:// only.
This commit is contained in:
amitwh
2026-06-08 07:35:54 +05:30
parent 1715e26e5f
commit c5d4b113bd
6 changed files with 25 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/component/UpdateBanner.test.tsx
+8 -1
View File
@@ -40,10 +40,17 @@ describe('UpdateBanner', () => {
expect(screen.getByText(/couldn.?t check/i)).toBeInTheDocument();
});
test('shows download CTA when state is available', () => {
useUpdaterStore.setState({ state: 'available', version: '5.0.2' });
render(<UpdateBanner />);
expect(screen.getByText(/5\.0\.2/)).toBeInTheDocument();
expect(screen.getByText(/download/i)).toBeInTheDocument();
});
test('restart button calls ipc.updater.install', () => {
useUpdaterStore.setState({ state: 'ready', version: '5.0.2' });
render(<UpdateBanner />);
fireEvent.click(screen.getByRole('button', { name: /restart/i }));
expect(useUpdaterStore.getState().install).toBeDefined();
});
});
});
tests/unit/main/updater/feed-config.test.js
+1 -32
View File
@@ -1,36 +1,5 @@
const { resolveFeedUrl, feedConfigFor, FEEDS } = require('../../../../src/main/updater/feed-config');
const { feedConfigFor } = require('../../../../src/main/updater/feed-config');
describe('feed-config', () => {
test('resolves github channel to GitHub Releases feed', () => {
const url = resolveFeedUrl('github', '5.0.2', 'mac');
expect(url).toBe('https://github.com/amitwh/markdown-converter/releases/download/v5.0.2/latest-mac.yml');
});
test('resolves concreteinfo channel to CI feed', () => {
const url = resolveFeedUrl('concreteinfo', '5.0.2', 'mac');
expect(url).toBe('https://updates.concreteinfo.co.in/v5/latest-mac.yml');
});
test('resolves windows platform correctly', () => {
const url = resolveFeedUrl('github', '5.0.2', 'windows');
expect(url).toContain('latest-windows.yml');
});
test('resolves linux platform correctly', () => {
const url = resolveFeedUrl('github', '5.0.2', 'linux');
expect(url).toContain('latest-linux.yml');
});
test('falls back to github on unknown channel', () => {
const url = resolveFeedUrl('something-weird', '5.0.2', 'mac');
expect(url).toContain('github.com');
});
test('exports both feeds as constants', () => {
expect(FEEDS.github).toBeDefined();
expect(FEEDS.concreteinfo).toBeDefined();
});
});
describe('feedConfigFor', () => {
test('returns github provider config for github channel', () => {
const config = feedConfigFor('github');