amitwh/markdown-converter
1
0
Fork 0
mirror of https://github.com/amitwh/markdown-converter.git synced 2026-08-02 18:10:18 +05:30
Code Issues Packages Projects Releases Wiki Activity

fix(polish): address 3 review blockers + 1 security issue

Browse Source 
1. ThemeSettings: change 'auto' radio value to 'system' to match
   the v5 settingsSchema enum. Storing 'auto' silently wipes all
   settings on next launch.
2. UpdateBanner: render an 'available' branch so users see a CTA
   when a new version is detected (the store already had this state,
   but the banner was silent). Added a test.
3. feed-config: remove the unused resolveFeedUrl / FEEDS exports.
   feedConfigFor is the actual implementation used by the IPC
   handler. Updated tests to match.
4. main/index.js: tighten app:open-external regex to https:// only.
This commit is contained in:
amitwh
2026-06-08 07:35:54 +05:30
parent 1715e26e5f
commit c5d4b113bd
6 changed files with 25 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/index.js
+1 -1
View File
@@ -2260,7 +2260,7 @@ ipcMain.on('app:quit', () => {
});
ipcMain.on('app:open-external', (_event, url) => {
if (typeof url === 'string' && /^https?:\/\//i.test(url)) {
if (typeof url === 'string' && /^https:\/\//i.test(url)) {
shell.openExternal(url).catch((e) => console.error('[app:open-external]', e));
}
});