fix(flowchart): expose pure modules as window globals for standalone window; v4.9.7

mirror of https://github.com/amitwh/markdown-converter.git synced 2026-10-01 09:19:34 +05:30

Each pure module's UMD wrapper assigned window.FlowchartXxx only in the else branch — when 'module' was undefined. But the renderer runs with nodeIntegration:true, so 'module' is always truthy and the else branch never ran. The standalone Flowchart Generator window then aborted with 'Flowchart pure modules not loaded'.

Fix: append 'if (typeof window !== undefined) window.FlowchartXxx = exported;' after the CommonJS branch in all 4 pure modules (store, shapes, mermaid, canvas). Both branches can run now; the legacy sidebar panel still loads them via require() and the renderer unconditionally exposes the global.

Regression guard: 4 new source-grep tests in tests/flowchart-controller.test.js assert each module's source contains the 'window.FlowchartXxx = exported' assignment.

Attribution: Amit Haridas

This commit is contained in:

amitwh

2026-09-14 23:59:50 +05:30

parent 5f846d1e5f

commit 86d4c0d23a

8 changed files with 53 additions and 2 deletions

README.md

+1 -1

View File

@@ -257,4 +257,4 @@ Amit Haridas (amit.wh@gmail.com)
 ## Version
 v4.9.6
 v4.9.7