From 487ce2ad45c35471d5808eef511849ffbac71a98 Mon Sep 17 00:00:00 2001
From: Amit Haridas <amit@example.com>
Date: Fri, 5 Jun 2026 15:58:21 +0530
Subject: [PATCH] feat(renderer): Toolbar wired to command store

- 5 functional buttons: Open file, Open folder, Save, Toggle sidebar, Toggle preview
- each dispatches via useCommandStore
- aria-pressed on toggle buttons reflects app store state
- formatting buttons (bold, italic, etc.) stay disabled (Phase 9)
- toolbar now has role='toolbar' and aria-label
- TDD: 9 component tests
---
 src/renderer/components/layout/Toolbar.tsx | 80 ++++++++++++++++---
 tests/component/layout/Toolbar.test.tsx    | 93 +++++++++++++++++++++-
 2 files changed, 161 insertions(+), 12 deletions(-)

diff --git a/src/renderer/components/layout/Toolbar.tsx b/src/renderer/components/layout/Toolbar.tsx
index c9dc98c..b82449d 100644
--- a/src/renderer/components/layout/Toolbar.tsx
+++ b/src/renderer/components/layout/Toolbar.tsx
@@ -1,15 +1,77 @@
-import { Bold, Italic, List, ListOrdered, Code, Link as LinkIcon } from 'lucide-react';
+import { Bold, Italic, List, ListOrdered, Code, Link as LinkIcon, PanelLeft, PanelRight, Save, FolderOpen, FileText } from 'lucide-react';
 import { Button } from '@/components/ui/button';
+import { useCommandStore } from '@/stores/command-store';
+import { useAppStore } from '@/stores/app-store';
 
 export function Toolbar() {
+  const dispatch = useCommandStore((s) => s.dispatch);
+  const { sidebarVisible, previewVisible } = useAppStore();
+
   return (
-    <div className="flex h-10 items-center gap-1 border-b border-border bg-card/10 px-3">
-      <Button variant="ghost" size="icon" aria-label="Bold"><Bold className="h-4 w-4" /></Button>
-      <Button variant="ghost" size="icon" aria-label="Italic"><Italic className="h-4 w-4" /></Button>
-      <Button variant="ghost" size="icon" aria-label="Unordered list"><List className="h-4 w-4" /></Button>
-      <Button variant="ghost" size="icon" aria-label="Ordered list"><ListOrdered className="h-4 w-4" /></Button>
-      <Button variant="ghost" size="icon" aria-label="Code"><Code className="h-4 w-4" /></Button>
-      <Button variant="ghost" size="icon" aria-label="Link"><LinkIcon className="h-4 w-4" /></Button>
+    <div
+      role="toolbar"
+      aria-label="Main toolbar"
+      className="flex h-10 items-center gap-1 border-b border-border bg-card/10 px-3"
+    >
+      <Button
+        variant="ghost"
+        size="icon"
+        aria-label="Open file"
+        data-testid="toolbar-open-file"
+        onClick={() => dispatch('file.open')}
+      >
+        <FileText className="h-4 w-4" />
+      </Button>
+      <Button
+        variant="ghost"
+        size="icon"
+        aria-label="Open folder"
+        data-testid="toolbar-open-folder"
+        onClick={() => dispatch('file.openFolder')}
+      >
+        <FolderOpen className="h-4 w-4" />
+      </Button>
+      <Button
+        variant="ghost"
+        size="icon"
+        aria-label="Save"
+        data-testid="toolbar-save"
+        onClick={() => dispatch('file.save')}
+      >
+        <Save className="h-4 w-4" />
+      </Button>
+
+      <div className="mx-1 h-5 w-px bg-border" aria-hidden="true" />
+
+      <Button
+        variant="ghost"
+        size="icon"
+        aria-label="Toggle sidebar"
+        aria-pressed={sidebarVisible}
+        data-testid="toolbar-toggle-sidebar"
+        onClick={() => dispatch('view.toggleSidebar')}
+      >
+        <PanelLeft className="h-4 w-4" />
+      </Button>
+      <Button
+        variant="ghost"
+        size="icon"
+        aria-label="Toggle preview"
+        aria-pressed={previewVisible}
+        data-testid="toolbar-toggle-preview"
+        onClick={() => dispatch('view.togglePreview')}
+      >
+        <PanelRight className="h-4 w-4" />
+      </Button>
+
+      <div className="mx-1 h-5 w-px bg-border" aria-hidden="true" />
+
+      <Button variant="ghost" size="icon" aria-label="Bold" disabled><Bold className="h-4 w-4" /></Button>
+      <Button variant="ghost" size="icon" aria-label="Italic" disabled><Italic className="h-4 w-4" /></Button>
+      <Button variant="ghost" size="icon" aria-label="Unordered list" disabled><List className="h-4 w-4" /></Button>
+      <Button variant="ghost" size="icon" aria-label="Ordered list" disabled><ListOrdered className="h-4 w-4" /></Button>
+      <Button variant="ghost" size="icon" aria-label="Code" disabled><Code className="h-4 w-4" /></Button>
+      <Button variant="ghost" size="icon" aria-label="Link" disabled><LinkIcon className="h-4 w-4" /></Button>
     </div>
   );
-}
\ No newline at end of file
+}
diff --git a/tests/component/layout/Toolbar.test.tsx b/tests/component/layout/Toolbar.test.tsx
index 9c49cad..62ca379 100644
--- a/tests/component/layout/Toolbar.test.tsx
+++ b/tests/component/layout/Toolbar.test.tsx
@@ -1,11 +1,98 @@
-import { describe, it, expect } from 'vitest';
-import { render, screen } from '@testing-library/react';
+import { describe, it, expect, beforeEach, vi } from 'vitest';
+import { render, screen, fireEvent, act } from '@testing-library/react';
 import { Toolbar } from '@/components/layout/Toolbar';
+import { useCommandStore } from '@/stores/command-store';
+import { useAppStore } from '@/stores/app-store';
 
 describe('Toolbar', () => {
+  beforeEach(() => {
+    useCommandStore.setState({ handlers: {} });
+    useAppStore.setState({
+      sidebarVisible: true,
+      previewVisible: true,
+      zenMode: false,
+      paneSizes: { sidebar: 20, editor: 50, preview: 30 },
+    });
+  });
+
   it('renders formatting buttons', () => {
     render(<Toolbar />);
     expect(screen.getByRole('button', { name: /bold/i })).toBeInTheDocument();
     expect(screen.getByRole('button', { name: /italic/i })).toBeInTheDocument();
   });
-});
\ No newline at end of file
+
+  it('renders all toolbar buttons', () => {
+    render(<Toolbar />);
+    expect(screen.getByTestId('toolbar-open-file')).toBeInTheDocument();
+    expect(screen.getByTestId('toolbar-open-folder')).toBeInTheDocument();
+    expect(screen.getByTestId('toolbar-save')).toBeInTheDocument();
+    expect(screen.getByTestId('toolbar-toggle-sidebar')).toBeInTheDocument();
+    expect(screen.getByTestId('toolbar-toggle-preview')).toBeInTheDocument();
+  });
+
+  it('Open file button dispatches file.open', () => {
+    const handler = vi.fn();
+    useCommandStore.getState().register('file.open', handler);
+    render(<Toolbar />);
+    fireEvent.click(screen.getByTestId('toolbar-open-file'));
+    expect(handler).toHaveBeenCalledTimes(1);
+  });
+
+  it('Open folder button dispatches file.openFolder', () => {
+    const handler = vi.fn();
+    useCommandStore.getState().register('file.openFolder', handler);
+    render(<Toolbar />);
+    fireEvent.click(screen.getByTestId('toolbar-open-folder'));
+    expect(handler).toHaveBeenCalledTimes(1);
+  });
+
+  it('Save button dispatches file.save', () => {
+    const handler = vi.fn();
+    useCommandStore.getState().register('file.save', handler);
+    render(<Toolbar />);
+    fireEvent.click(screen.getByTestId('toolbar-save'));
+    expect(handler).toHaveBeenCalledTimes(1);
+  });
+
+  it('Toggle sidebar button dispatches view.toggleSidebar and reflects aria-pressed', () => {
+    const handler = vi.fn();
+    useCommandStore.getState().register('view.toggleSidebar', handler);
+    render(<Toolbar />);
+    const btn = screen.getByTestId('toolbar-toggle-sidebar');
+    expect(btn).toHaveAttribute('aria-pressed', 'true');
+    fireEvent.click(btn);
+    expect(handler).toHaveBeenCalledTimes(1);
+  });
+
+  it('Toggle preview button dispatches view.togglePreview', () => {
+    const handler = vi.fn();
+    useCommandStore.getState().register('view.togglePreview', handler);
+    render(<Toolbar />);
+    fireEvent.click(screen.getByTestId('toolbar-toggle-preview'));
+    expect(handler).toHaveBeenCalledTimes(1);
+  });
+
+  it('toggle sidebar end-to-end: command flips appStore state, aria-pressed reflects it', () => {
+    useCommandStore.getState().register('view.toggleSidebar', () => {
+      useAppStore.getState().toggleSidebar();
+    });
+    render(<Toolbar />);
+    const btn = screen.getByTestId('toolbar-toggle-sidebar');
+    expect(btn).toHaveAttribute('aria-pressed', 'true');
+    act(() => {
+      fireEvent.click(btn);
+    });
+    expect(useAppStore.getState().sidebarVisible).toBe(false);
+    expect(btn).toHaveAttribute('aria-pressed', 'false');
+  });
+
+  it('formatting buttons (bold, italic, etc.) are disabled (Phase 9 work)', () => {
+    render(<Toolbar />);
+    expect(screen.getByLabelText('Bold')).toBeDisabled();
+    expect(screen.getByLabelText('Italic')).toBeDisabled();
+    expect(screen.getByLabelText('Unordered list')).toBeDisabled();
+    expect(screen.getByLabelText('Ordered list')).toBeDisabled();
+    expect(screen.getByLabelText('Code')).toBeDisabled();
+    expect(screen.getByLabelText('Link')).toBeDisabled();
+  });
+});