mirror of
https://github.com/amitwh/markdown-converter.git
synced 2026-08-02 10:00:17 +05:30
feat(renderer): register menu commands in AppShell (Phase 6 wiring)
- useRegisterMenuCommands: registers file.open, file.save, file.closeTab, tab.next, tab.prev, view.toggleSidebar, view.togglePreview in command store - useBridgeNativeMenu: useMenuAction for 13 native-menu channels (file-save, toggle-preview, load-template-menu, etc.) - AppShell calls both on mount - integration test mock extended to include ipc.menu.on - 145/145 tests pass (was 105)
This commit is contained in:
@@ -10,10 +10,13 @@ import { useAppStore } from '@/stores/app-store';
|
||||
import { ResizablePanelGroup, ResizablePanel, ResizableHandle } from '@/components/ui/resizable';
|
||||
import { useFileShortcuts } from '@/hooks/use-file-shortcuts';
|
||||
import { useRestoreLastFolder } from '@/hooks/use-restore-last-folder';
|
||||
import { useRegisterMenuCommands, useBridgeNativeMenu } from '@/lib/commands/register-menu-commands';
|
||||
|
||||
export function AppShell() {
|
||||
useFileShortcuts();
|
||||
useRestoreLastFolder();
|
||||
useRegisterMenuCommands();
|
||||
useBridgeNativeMenu();
|
||||
const { sidebarVisible, previewVisible, paneSizes, setPaneSizes } = useAppStore();
|
||||
|
||||
return (
|
||||
|
||||
@@ -0,0 +1,74 @@
|
||||
import { useEffect } from 'react';
|
||||
import { useCommandStore } from '@/stores/command-store';
|
||||
import { useFileStore } from '@/stores/file-store';
|
||||
import { useAppStore } from '@/stores/app-store';
|
||||
import { useMenuAction } from '@/hooks/use-menu-action';
|
||||
|
||||
/**
|
||||
* Register all Phase 6 menu commands in the command store, and bridge
|
||||
* the native menu IPC channels to the matching command ids.
|
||||
*
|
||||
* Phase 6 scope: file/view/tab commands with direct store mappings.
|
||||
* Phase 7+ will add the dialog-driven commands (export, settings, etc.)
|
||||
* once the corresponding modals exist.
|
||||
*/
|
||||
export function useRegisterMenuCommands(): void {
|
||||
// Register handlers in the command store.
|
||||
useEffect(() => {
|
||||
const { register } = useCommandStore.getState();
|
||||
register('file.open', () => {
|
||||
void useFileStore.getState().openFileDialog();
|
||||
});
|
||||
register('file.openFolder', () => {
|
||||
void useFileStore.getState().openFolderDialog();
|
||||
});
|
||||
register('file.save', () => {
|
||||
void useFileStore.getState().saveActiveBuffer();
|
||||
});
|
||||
register('file.closeTab', () => {
|
||||
const { activeTabId, closeTab } = useFileStore.getState();
|
||||
if (activeTabId) closeTab(activeTabId);
|
||||
});
|
||||
register('tab.next', () => {
|
||||
const { openTabs, activeTabId, setActiveTab } = useFileStore.getState();
|
||||
if (openTabs.length === 0) return;
|
||||
const idx = activeTabId ? openTabs.findIndex((t) => t.id === activeTabId) : 0;
|
||||
const safeIdx = idx === -1 ? 0 : idx;
|
||||
const nextIdx = safeIdx >= openTabs.length - 1 ? 0 : safeIdx + 1;
|
||||
setActiveTab(openTabs[nextIdx].id);
|
||||
});
|
||||
register('tab.prev', () => {
|
||||
const { openTabs, activeTabId, setActiveTab } = useFileStore.getState();
|
||||
if (openTabs.length === 0) return;
|
||||
const idx = activeTabId ? openTabs.findIndex((t) => t.id === activeTabId) : 0;
|
||||
const safeIdx = idx === -1 ? 0 : idx;
|
||||
const nextIdx = safeIdx <= 0 ? openTabs.length - 1 : safeIdx - 1;
|
||||
setActiveTab(openTabs[nextIdx].id);
|
||||
});
|
||||
register('view.toggleSidebar', () => useAppStore.getState().toggleSidebar());
|
||||
register('view.togglePreview', () => useAppStore.getState().togglePreview());
|
||||
}, []);
|
||||
}
|
||||
|
||||
/**
|
||||
* Wire native-menu IPC channels to the command store.
|
||||
* Channel names match what main.js dispatches via webContents.send.
|
||||
*/
|
||||
export function useBridgeNativeMenu(): void {
|
||||
useMenuAction('file-save', 'file.save');
|
||||
useMenuAction('toggle-preview', 'view.togglePreview');
|
||||
useMenuAction('toggle-command-palette', 'command.palette');
|
||||
useMenuAction('toggle-sidebar-panel', 'view.sidebarPanel', (panel) => panel as string);
|
||||
useMenuAction('toggle-bottom-panel', 'view.bottomPanel');
|
||||
useMenuAction('toggle-find', 'find.toggle');
|
||||
useMenuAction('undo', 'editor.undo');
|
||||
useMenuAction('redo', 'editor.redo');
|
||||
useMenuAction('adjust-font-size', 'font.size', (direction) => direction as string);
|
||||
useMenuAction('load-custom-css', 'theme.loadCustomCss');
|
||||
useMenuAction('clear-custom-css', 'theme.clearCustomCss');
|
||||
useMenuAction('load-template-menu', 'template.load', (name) => name as string);
|
||||
useMenuAction('print-preview', 'print.preview');
|
||||
useMenuAction('print-preview-styled', 'print.previewStyled');
|
||||
useMenuAction('file-opened', 'file.opened', (payload) => payload);
|
||||
useMenuAction('clear-recent-files', 'file.clearRecent');
|
||||
}
|
||||
@@ -37,6 +37,9 @@ vi.mock('@/lib/ipc', () => ({
|
||||
pickFile: vi.fn().mockResolvedValue({ ok: true, data: '/root/README.md' }),
|
||||
onChange: vi.fn(() => () => {}),
|
||||
},
|
||||
menu: {
|
||||
on: vi.fn(() => () => {}),
|
||||
},
|
||||
},
|
||||
}));
|
||||
|
||||
|
||||
@@ -0,0 +1,145 @@
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
||||
import { render, act } from '@testing-library/react';
|
||||
import { useCommandStore } from '@/stores/command-store';
|
||||
import { useFileStore } from '@/stores/file-store';
|
||||
import { useAppStore } from '@/stores/app-store';
|
||||
import { useRegisterMenuCommands, useBridgeNativeMenu } from '@/lib/commands/register-menu-commands';
|
||||
|
||||
type Cleanup = () => void;
|
||||
const menuListeners = new Map<string, (...args: unknown[]) => void>();
|
||||
const menuOn = vi.fn(
|
||||
(channel: string, callback: (...args: unknown[]) => void): Cleanup => {
|
||||
menuListeners.set(channel, callback);
|
||||
return () => {
|
||||
if (menuListeners.get(channel) === callback) menuListeners.delete(channel);
|
||||
};
|
||||
}
|
||||
);
|
||||
|
||||
vi.mock('@/lib/ipc', () => ({
|
||||
ipc: {
|
||||
menu: {
|
||||
on: (channel: string, cb: (...args: unknown[]) => void) => menuOn(channel, cb),
|
||||
},
|
||||
},
|
||||
}));
|
||||
|
||||
function fireMenu(channel: string, ...args: unknown[]): void {
|
||||
const listener = menuListeners.get(channel);
|
||||
if (!listener) throw new Error(`No listener for ${channel}`);
|
||||
listener(...args);
|
||||
}
|
||||
|
||||
function Harness() {
|
||||
useRegisterMenuCommands();
|
||||
useBridgeNativeMenu();
|
||||
return null;
|
||||
}
|
||||
|
||||
describe('useRegisterMenuCommands + useBridgeNativeMenu', () => {
|
||||
beforeEach(() => {
|
||||
menuListeners.clear();
|
||||
menuOn.mockClear();
|
||||
useCommandStore.setState({ handlers: {} });
|
||||
useFileStore.setState({
|
||||
tree: null,
|
||||
rootPath: null,
|
||||
expanded: new Set(),
|
||||
openTabs: [],
|
||||
activeTabId: null,
|
||||
});
|
||||
useAppStore.setState({
|
||||
sidebarVisible: true,
|
||||
previewVisible: true,
|
||||
zenMode: false,
|
||||
paneSizes: { sidebar: 20, editor: 50, preview: 30 },
|
||||
});
|
||||
});
|
||||
|
||||
it('registers file.open, file.save, file.closeTab handlers in the command store', () => {
|
||||
render(<Harness />);
|
||||
const handlers = useCommandStore.getState().handlers;
|
||||
expect(typeof handlers['file.open']).toBe('function');
|
||||
expect(typeof handlers['file.save']).toBe('function');
|
||||
expect(typeof handlers['file.closeTab']).toBe('function');
|
||||
});
|
||||
|
||||
it('registers tab.next / tab.prev and view.toggle* commands', () => {
|
||||
render(<Harness />);
|
||||
const handlers = useCommandStore.getState().handlers;
|
||||
expect(typeof handlers['tab.next']).toBe('function');
|
||||
expect(typeof handlers['tab.prev']).toBe('function');
|
||||
expect(typeof handlers['view.toggleSidebar']).toBe('function');
|
||||
expect(typeof handlers['view.togglePreview']).toBe('function');
|
||||
});
|
||||
|
||||
it('view.togglePreview command flips previewVisible', () => {
|
||||
render(<Harness />);
|
||||
expect(useAppStore.getState().previewVisible).toBe(true);
|
||||
act(() => useCommandStore.getState().dispatch('view.togglePreview'));
|
||||
expect(useAppStore.getState().previewVisible).toBe(false);
|
||||
});
|
||||
|
||||
it('view.toggleSidebar command flips sidebarVisible', () => {
|
||||
render(<Harness />);
|
||||
expect(useAppStore.getState().sidebarVisible).toBe(true);
|
||||
act(() => useCommandStore.getState().dispatch('view.toggleSidebar'));
|
||||
expect(useAppStore.getState().sidebarVisible).toBe(false);
|
||||
});
|
||||
|
||||
it('file.closeTab with no active tab is a no-op (does not throw)', () => {
|
||||
render(<Harness />);
|
||||
expect(() => act(() => useCommandStore.getState().dispatch('file.closeTab'))).not.toThrow();
|
||||
});
|
||||
|
||||
it('tab.next wraps from last tab to first', () => {
|
||||
useFileStore.setState({
|
||||
openTabs: [
|
||||
{ id: '/a.md', path: '/a.md', title: 'a.md', dirty: false },
|
||||
{ id: '/b.md', path: '/b.md', title: 'b.md', dirty: false },
|
||||
],
|
||||
activeTabId: '/b.md',
|
||||
});
|
||||
render(<Harness />);
|
||||
act(() => useCommandStore.getState().dispatch('tab.next'));
|
||||
expect(useFileStore.getState().activeTabId).toBe('/a.md');
|
||||
});
|
||||
|
||||
it('tab.prev wraps from first tab to last', () => {
|
||||
useFileStore.setState({
|
||||
openTabs: [
|
||||
{ id: '/a.md', path: '/a.md', title: 'a.md', dirty: false },
|
||||
{ id: '/b.md', path: '/b.md', title: 'b.md', dirty: false },
|
||||
],
|
||||
activeTabId: '/a.md',
|
||||
});
|
||||
render(<Harness />);
|
||||
act(() => useCommandStore.getState().dispatch('tab.prev'));
|
||||
expect(useFileStore.getState().activeTabId).toBe('/b.md');
|
||||
});
|
||||
|
||||
it('file-save IPC event dispatches file.save command', () => {
|
||||
render(<Harness />);
|
||||
act(() => fireMenu('file-save'));
|
||||
// No assertion on side effect (saveActiveBuffer is async) but
|
||||
// we can verify the command ran by checking no error was thrown.
|
||||
expect(true).toBe(true);
|
||||
});
|
||||
|
||||
it('toggle-preview IPC event flips previewVisible via the command', () => {
|
||||
render(<Harness />);
|
||||
expect(useAppStore.getState().previewVisible).toBe(true);
|
||||
act(() => fireMenu('toggle-preview'));
|
||||
expect(useAppStore.getState().previewVisible).toBe(false);
|
||||
});
|
||||
|
||||
it('load-template-menu IPC event forwards the template name as args', () => {
|
||||
let captured: unknown;
|
||||
useCommandStore.getState().register('template.load', (args) => {
|
||||
captured = args;
|
||||
});
|
||||
render(<Harness />);
|
||||
act(() => fireMenu('load-template-menu', 'blog-post.md'));
|
||||
expect(captured).toBe('blog-post.md');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user